perf: Remove redundant JSON stringify-parse cycle in HTTP response toJSON method

alvidofaisal · alvidofaisal · commit 8dbda20a97da · 2025-06-15T03:18:43.000+07:00
Eliminates unnecessary performance overhead by returning parseJSON(str) directly instead of converting the already-parsed JavaScript object to a JSON string and then parsing it back. HTTP response data doesn't contain circular references that would require safeJsonStringify processing.

Signed-off-by: alvidofaisal &lt;alvidofaisal@gmail.com&gt;
diff --git a/packages/core/http/http-request/index.android.ts b/packages/core/http/http-request/index.android.ts
@@ -153,8 +153,7 @@ function onRequestComplete(requestId: number, result: org.nativescript.widgets.A
 					str = result.responseAsString;
 				}
 
-				// Use safeJsonStringify instead of parseJSON directly
-				return JSON.parse(safeJsonStringify(parseJSON(str)));
+				return parseJSON(str);
 			},
 			toImage: () => {
 				ensureImageSource();

Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,7 @@ function onRequestComplete(requestId: number, result: org.nativescript.widgets.A`
`153`	`153`	`str = result.responseAsString;`
`154`	`154`	`}`
`155`	`155`
`156`		`- // Use safeJsonStringify instead of parseJSON directly`
`157`		`- return JSON.parse(safeJsonStringify(parseJSON(str)));`
	`156`	`+ return parseJSON(str);`
`158`	`157`	`},`
`159`	`158`	`toImage: () => {`
`160`	`159`	`ensureImageSource();`