Fix posture management and include option for idling posture. #771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| match (polling llm request response).Started() | ||
| start bot posture "Thinking, idle" as $posture | ||
| match (polling llm request response).Finished() | ||
| if not $bot_talking_state |
Collaborator
There was a problem hiding this comment.
This seems to unnecessary since we already check before?
Collaborator
Author
There was a problem hiding this comment.
I think the issue here is that since this in a separate loop you can have the StartPostureBotAction() at the "same time" as a StartUtteranceBotAction() from a different loop. (So basically, the value of $bot_talking_state changes during the line 285 so we check again on 286).
Collaborator
There was a problem hiding this comment.
Good point... That seems to call for an additional Colang feature imo. Something to define a scope where a certain state must hold...
Collaborator
Author
There was a problem hiding this comment.
Yes I agree. We should think about that.
schuellc-nvidia
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colang 2.0 Standard Library Fix, that