Add "Themed Icons" for Android #220
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileychh
added
type: enhancement
Member
Author
|
Just found out that the edit: to use this unreleased feature, we need to switch to the latest master version. |
rileychh
changed the title
rileychh
changed the title
rileychh
force-pushed
the
android-themed-icons
branch
from
5be76a7 to
7046e7b
Compare
Member
Author
|
Re-implemented with |
Run `flutter pub run flutter_launcher_icons`.
rileychh
force-pushed
the
android-themed-icons
branch
from
7046e7b to
59a00dd
Compare
Member
Author
|
Please note that this PR is blocked by #224. Without a proper splash screen for Android 12 and later, the app will launch with 2 splash screens. Demonstration: Details about double splash screen: https://stackoverflow.com/questions/77098464/play-console-pre-launch-warning-double-splash-screen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for Themed Icons on Android. This feature allows users running Android 13 or later theme our app icon based on the system theme.
Implementation
flutter_launcher_iconswith the version added support for themed icons.android.pngwith the background removed as the foreground for the adaptive icon.tat.pngtooriginal.png, and use this image for iOS and older Android versions.Testing Instructions
Install the app on Android, drag a shortcut onto the home screen, and enable "Themed Icons" in the launcher settings. Verify that the TAT logo correctly follows the system theme.
Additional Notes
N/A.