Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r] add support for multiclass cliassification #210

Merged
merged 26 commits into from
May 7, 2020
Merged

[r] add support for multiclass cliassification #210

merged 26 commits into from
May 7, 2020

Conversation

maksymiuks
Copy link
Member

@maksymiuks maksymiuks commented Apr 27, 2020 •
edited by hbaniecki
Loading

closes #208

@maksymiuks maksymiuks requested a review from pbiecek April 27, 2020 22:58
@maksymiuks maksymiuks added feature 💡 New feature or enhancement request R 🐳 Related to R labels Apr 28, 2020
pbiecek
pbiecek reviewed Apr 29, 2020
View reviewed changes
R/misc_yhat.R Outdated Show resolved Hide resolved
R/misc_yhat.R Outdated Show resolved Hide resolved
R/misc_yhat.R Outdated Show resolved Hide resolved
R/misc_yhat.R Show resolved Hide resolved
R/model_info.R Outdated Show resolved Hide resolved
R/model_performance.R Outdated Show resolved Hide resolved
R/model_performance.R Show resolved Hide resolved
R/model_performance.R
}

calculate_confusion_matrixes <- function(predicted, observed){
observed <- as.character(observed)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what would happen is one of these conditions are not satisfied (eg all predictions are TRUE)
would it work or cause errors?

Copy link
Member Author

@maksymiuks maksymiuks Apr 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added ifelse statement that checks if one of the values is NaN before assigning it to a list

@pbiecek pbiecek marked this pull request as draft April 29, 2020 10:18
@maksymiuks maksymiuks marked this pull request as ready for review April 29, 2020 14:43
@maksymiuks maksymiuks requested a review from pbiecek April 29, 2020 16:11
@hbaniecki
Copy link
Member

#208

@hbaniecki hbaniecki mentioned this pull request May 5, 2020
Merged
@maksymiuks maksymiuks changed the title Issue #208 Issue #208 and #218 May 5, 2020
@maksymiuks maksymiuks mentioned this pull request May 5, 2020
Closed
@maksymiuks maksymiuks mentioned this pull request May 5, 2020
Closed
@hbaniecki hbaniecki changed the title Issue #208 and #218 [r] add support for multiclass cliassification May 5, 2020
pbiecek
pbiecek reviewed May 5, 2020
View reviewed changes
NEWS.md Outdated Show resolved Hide resolved
NEWS.md Outdated Show resolved Hide resolved
R/explain.R Outdated Show resolved Hide resolved
R/explain.R Outdated Show resolved Hide resolved
@pbiecek
Copy link
Member

pbiecek commented May 7, 2020

thanks

@pbiecek pbiecek merged commit 05aa82a into master May 7, 2020
pbiecek added a commit that referenced this pull request May 7, 2020
@pbiecek
fixed function names and documentation for #210
a58c0b0
@hbaniecki hbaniecki deleted the issue_#208 branch July 11, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbiecek pbiecek pbiecek left review comments

Assignees
No one assigned
Labels
feature 💡 New feature or enhancement request R 🐳 Related to R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce measures for multilabel classification
3 participants
@maksymiuks @hbaniecki @pbiecek