Codecov Report

Merging #929 into master will increase coverage by 0.13%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #929      +/-   ##
==========================================
+ Coverage   17.66%    17.8%   +0.13%     
==========================================
  Files         228      230       +2     
  Lines      139621   139889     +268     
  Branches    12379    12406      +27     
==========================================
+ Hits        24667    24903     +236     
- Misses     114008   114035      +27     
- Partials      946      951       +5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f76a800...3425ac2. Read the comment docs.

We encountered an issue when trying to use latest TraceEvent nuget package. Trace sessions are stopped unexpected due to GC-ed TraceEventSession objects. So propose this fix, as current logic will caused trouble to users whoever uses GetActionSession method right after creating the real trace session.

@ZhaminXu, thanks for the contribution. Do you know which line(s) in Dispose() are causing the attached session to be closed? I'm concerned that we might leak resources if Dispose doesn't get called at all even in the attach case.

@ZhaminXu, thanks for the contribution. Do you know which line(s) in Dispose() are causing the attached session to be closed? I'm concerned that we might leak resources if Dispose doesn't get called at all even in the attach case.
Yes, it's Stop(true) method. I also checked more code there. If TraceEventSession is created and attached, m_sessionHandle is invliad, m_source and m_kernelSession are not used. So I think it's safe to skip the entire dispose method. But after thinking carefully, I think your concern is valid. let me try to just skip the stop method.