-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable ImageView #56
Comments
+1 I've got similar issue with animated I think possibility of providing custom |
Hey @ivanbruel & @twalenciak ImageViewer changed a lot in v3.0. Now there is only the I'm thinking if you create an extension on Would this solve the issue? Have you updated to v3.1 or v4.0 yet? |
Ok, looking at the issue a bit closer, I've implemented a way to add custom ViewControllers to the gallery - this view controller can then work with a custom view Any feedback welcome! :) |
Hopefully #80 helps if you need a custom GalleryItem. Closing for now but hoping to get some feedback @ivanbruel and @twalenciak if you find the time :) |
I've been using Kingfisher as my image loading dependency alongside its
AnimatedImageView
which adds support for GIF loading.As such, in order to take advantage of this in
ImageViewer
I had to make theimageView
property public in theImageViewerController
class.As this might be a problem for other people using different dependencies, might be nice to get this change into the library.
I've forked the project and made the change myself, let me know if it makes sense to open a pull request.
Example usage:
The text was updated successfully, but these errors were encountered: