Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: [event-report-template-variable] Added instance-wide report variables #10068

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

mokaddem
Copy link
Contributor

@mokaddem mokaddem commented Nov 28, 2024

Changed behavior of template variables:

  • With variables being saved as user setting only the creator of the report can use/see them
  • This change makes it so that only site-admin can create/edit/remove them but every other user can now use/see them

Warning

Breaking change: Any template variable defined in the user settings won't be used anymore. Migrate them to this new version.

New:

  • Complete CRUD for event-report template variables
  • New form field editor to hot replace textarea seamlessly
  • Removed user setting eventreport_template_variables

image

…able

- Changed behavior of template variables. With variables being saved as user setting
only the creator of the report can use/see them
- This change makes it so that only site-admin can create/edit/remove them but every
other user can now use/see them
@mokaddem mokaddem added UI This issue involves the user interface UX This issue involves the user experience topic: event report This issue involves the event report feature labels Nov 28, 2024
@mokaddem mokaddem merged commit 4a1b07c into 2.4-develop Nov 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: event report This issue involves the event report feature UI This issue involves the user interface UX This issue involves the user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant