Fix regression caused by #70 #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reprdouce: 1. install and setup Keywi 2. restart Firefox 3. cancel unlock dialog 4. try to fill in password Expected result: Password is filled Actual result: Nothing happens, because Keepass._ss is undefined Signed-off-by: Tobia De Koninck <[email protected]>
|
Did we have something like this before? I cannot find it :-) |
|
That one just moved, looking at the diff https://github.com/LEDfan/keywi/pull/70/files#diff-462f5d1db8d897cf020d8bac47f15d77R51 |
RobinJadoul
approved these changes
Sep 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Expected result:
Password is filled
Actual result:
Nothing happens, because Keepass._ss is undefined
Signed-off-by: Tobia De Koninck [email protected]