Remove any elements above input fields to fix cm #81
Conversation
|
I'm afraid this may break too much. |
Tried something similar, the problem is that you can't trigger the ContextMenu from client side JS for security reasons.. (e.g. https://stackoverflow.com/questions/24690031/chrome-extension-trigger-context-menu) |
|
Maybe setting otherwise, something more like this might work: https://stackoverflow.com/a/2243086 |
Some sites (e.g. login.live.com) don't use the HTML5 placeholder tag but uses a custom solution for this (probably because IE < 9 don't support this). By adding this script we remove any click handlers on these DOM elements living in front of the input field. The click event is then called on the input field instead of the overlapping elements. Signed-off-by: Tobia De Koninck <[email protected]>
This is an awesome idea and indeed works! Thanks! @RobinJadoul can you give this a last test? |
- rename fix-contenteditable.js to fix-contextmenu.js - add some comments about special parts of the code - replace setTimeout by a self calling function Signed-off-by: Tobia De Koninck <[email protected]>
Signed-off-by: Tobia De Koninck <[email protected]>
|
@RobinJadoul done |
Some sites (e.g. login.live.com) don't use the HTML5 placeholder tag but
uses a custom solution for this (probably because IE < 9 don't support
this). By adding this script we remove any DOM elements living in front
of the input field.
Fixes #80
@RobinJadoul please provide you opinion if this is the way to go, this has the potential to break some sites. We could also create some content_scripts specific for MS stuff, which are only loaded on the necessary sites. This makes Keywi somehow more bloated, but is probably more reliable.