Add annotations for ORES revision scores #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
he7d3r
force-pushed
the
ores
branch
2 times, most recently
from
1cb7d96 to
b8c8760
Compare
|
@Krinkle: just checking if you noticed this proposal. |
|
|
||
| // Find all revids names inside the feed | ||
| revids = []; | ||
| $feedContent.filter('.mw-rtrc-item').each(function () { |
There was a problem hiding this comment.
Using $.map() would simplify this code:
revids = $.map($feedContent.filter('.mw-rtrc-item'), function (node) {
return $(node).attr('data-diff');
});map() automatically filters out undefined/null from attr().
Krinkle
changed the title
| // Todo: reduce this once ores has better performance | ||
| // https://meta.wikimedia.org/wiki/Research_talk:Revision_scoring_as_a_service#ORES_performance_improvements | ||
| timeout: 30000, | ||
| dataType: 'jsonp', |
There was a problem hiding this comment.
Using JSONP means cache will still be broken because of the callback parameter. I've filed an issue upstream (https://github.com/wiki-ai/ores/issues/45) to support CORS/JSON instead.
|
BTW, ORES now supports CORS from Wikimedia sites. |
he7d3r
force-pushed
the
ores
branch
3 times, most recently
from
fa3621d to
129c7c0
Compare
The probabilities are obtained from ORES server. For details, see: * https://meta.wikimedia.org/wiki/Objective_Revision_Evaluation_Service * https://meta.wikimedia.org/wiki/Research:Revision_scoring_as_a_service
|
Updated to not use 'jsonp'. |
|
Thanks! |
Krinkle
added a commit
to wikimedia/labs-tools-intuition
that referenced
this pull request
Oct 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The probabilities are obtained from ores server. For details, see: