Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't 'edge_forward_spline_u` receive 'output_range_spline'? #501

Open
vssorru opened this issue Nov 27, 2024 · 0 comments
Open

Shouldn't 'edge_forward_spline_u` receive 'output_range_spline'? #501

vssorru opened this issue Nov 27, 2024 · 0 comments

Comments

@vssorru
Copy link

vssorru commented Nov 27, 2024

In MultKAN forward():

1- postacts = postacts_numerical + postacts_symbolic

2- output_range = torch.std(postacts, dim=0) # for visualization, include the contribution from both spline + symbolic

3- self.edge_actscale.append(output_range)

In MultKAN reg():

elif reg_metric == 'edge_forward_spline_u':

`acts_scale = self.edge_actscale`

so "'edge_forward_spline_u`: the “norm” of edge, unnormalized (output std), only consider the spline (ignoring symbolic)" is wrong?

to correct in forward():
self.edge_actscale.append(output_range_spline)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant