Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Support external linkage in "sysimages"" #47776

Closed
wants to merge 1 commit into from
Closed

Revert "Support external linkage in "sysimages"" #47776

wants to merge 1 commit into from

Conversation

DilumAluthge
Copy link
Member

Reverts #44527

@DilumAluthge DilumAluthge added DO NOT MERGE Do not merge this PR! revert This reverts a previously merged PR. labels Dec 2, 2022
@vchuravy
Copy link
Member

vchuravy commented Dec 2, 2022

Motivation is to see if the timeouts we see are related to the PR.

@vchuravy vchuravy added merge me PR is reviewed. Merge when all tests are passing and removed DO NOT MERGE Do not merge this PR! labels Dec 2, 2022
@vchuravy
Copy link
Member

vchuravy commented Dec 2, 2022

Well that's clear.

@vchuravy vchuravy marked this pull request as ready for review December 2, 2022 15:55
@vchuravy
Copy link
Member

vchuravy commented Dec 2, 2022

If at all possible I would like to do #47780 first since that changed the ABI and we already rebuilt the libjulia_jll

@vchuravy vchuravy mentioned this pull request Dec 3, 2022
Merged
@vchuravy vchuravy closed this Dec 3, 2022
@vchuravy vchuravy deleted the revert-44527-teh-vc/serialize_partial branch December 3, 2022 23:27
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
revert This reverts a previously merged PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DilumAluthge @vchuravy