fix bug when error is infinite #46436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscardssmith
added
maths
|
merge? |
35 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2022
(cherry picked from commit c491e79)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2022
(cherry picked from commit c491e79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I had assumed that the error terms were strictly smaller than the result (which is true), but the error terms can never the less be infinite, and because of the order in which things are computed (having to do with
fma) the error term was sometimes choosing the sign of the infinity which is bad.