Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing T_size->getSizeTy in llvm-ptls #44484

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Fix missing T_size->getSizeTy in llvm-ptls #44484

merged 1 commit into from
Mar 6, 2022

Conversation

vchuravy
Copy link
Member

@vchuravy vchuravy commented Mar 6, 2022

Should fix #44481

@vchuravy vchuravy requested a review from pchintalapudi March 6, 2022 14:38
@vchuravy vchuravy added the system:mac Affects only macOS label Mar 6, 2022
@fxcoudert
Copy link
Contributor

I confirm that it fixes the build for me on macOS aarch64.

@fxcoudert fxcoudert mentioned this pull request Mar 6, 2022
Closed
pchintalapudi
pchintalapudi approved these changes Mar 6, 2022
View reviewed changes
Copy link
Member

@pchintalapudi pchintalapudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, missed that T_size.

@vchuravy
Copy link
Member Author

vchuravy commented Mar 6, 2022

Cancelled the queue for the packager and queued up a build for this https://build.julialang.org/#/builders/34/builds/3930

@vchuravy vchuravy merged commit 3bcab39 into master Mar 6, 2022
@vchuravy vchuravy deleted the vc/fix_44481 branch March 6, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchintalapudi pchintalapudi pchintalapudi approved these changes

Assignees
No one assigned
Labels
embarrassing-bugfix Whoops! system:mac Affects only macOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Julia master fails to build on macOS
3 participants
@vchuravy @fxcoudert @pchintalapudi