Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segfault due to bad inference of overlayed merge #12

Closed
Keno opened this issue Nov 29, 2022 · 1 comment · Fixed by JuliaLang/julia#47739
Closed

Segfault due to bad inference of overlayed merge #12

Keno opened this issue Nov 29, 2022 · 1 comment · Fixed by JuliaLang/julia#47739
Assignees
@Keno

Comments

@Keno
Copy link
Member

Keno commented Nov 29, 2022 

using CassetteOverlay
@MethodTable SinTable;
pass = @overlaypass SinTable;
f() = Base.merge((;), Base.inferencebarrier((; a=1, b=2)))
pass(f)

[1722766] signal (4.2): Illegal instruction
in expression starting at REPL[7]:1
##SinTable#296 at ./REPL[6]:1 [inlined]
##SinTable#296 at /home/keno/.julia/dev/CassetteOverlay/src/CassetteOverlay.jl:0
@Keno
Copy link
Member Author

Keno commented Nov 29, 2022

This is likely some sort of base julia bug. It shouldn't have been allowed to expand the generator in inference if it didn't have total type information.

@Keno Keno self-assigned this Nov 29, 2022
Keno added a commit to JuliaLang/julia that referenced this issue Nov 29, 2022
@Keno
Fix generator-invocation legality check for varargs generators
d4151d2 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12
@Keno Keno mentioned this issue Nov 29, 2022
Merged
Keno added a commit to JuliaLang/julia that referenced this issue Nov 29, 2022
@Keno
Fix generator-invocation legality check for varargs generators
1a48687 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12
Keno added a commit to JuliaLang/julia that referenced this issue Nov 29, 2022
@Keno
Fix generator-invocation legality check for varargs generators (#47739)
328dd57 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Dec 8, 2022
@Keno @KristofferC
Fix generator-invocation legality check for varargs generators (#47739)
81f8582 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Dec 14, 2022
@Keno
Fix generator-invocation legality check for varargs generators (#47739)
68fcf0c 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Dec 14, 2022
@Keno
Fix generator-invocation legality check for varargs generators (#47739)
2950963 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Dec 21, 2022
@Keno
Fix generator-invocation legality check for varargs generators (#47739)
2ffdbea 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Dec 21, 2022
@Keno
Fix generator-invocation legality check for varargs generators (#47739)
0668ee4 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Dec 21, 2022
@Keno
Fix generator-invocation legality check for varargs generators (#47739)
d2eb584 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
staticfloat pushed a commit to JuliaLang/julia that referenced this issue Dec 23, 2022
@Keno @staticfloat
Fix generator-invocation legality check for varargs generators (#47739)
e3c9d9a 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
KristofferC pushed a commit to JuliaLang/julia that referenced this issue Oct 10, 2023
@Keno @KristofferC
Fix generator-invocation legality check for varargs generators (#47739)
1d1e82e 
This code was introduced by me back in #31025 to speed up evaluation
of generated functions that didn't make use of all of their arguments to
make generation decisions. However, it neglected to take into account the
possibility that the generator could be varargs. As a result, an unfortunate
coincidence of an unused slot in the correct position could have allowed
expansion of generators that were not supposed to be expandable. This can
cause incorrect inference with all the usual consequences. However, fortunately
this coincidence appears to be pretty rare.

Fixes JuliaDebug/CassetteOverlay.jl#12

(cherry picked from commit 328dd57)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keno Keno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix generator-invocation legality check for varargs generators JuliaLang/julia
1 participant
@Keno