Improve inferrability of lsf_rotate in Julia v1.10+ (#82)

giordano · web-flow · commit 4cd6c1656d74 · 2023-08-31T14:08:23.000+01:00
diff --git a/src/lsf_rotate.jl b/src/lsf_rotate.jl
@@ -7,7 +7,7 @@ function lsf_rotate(&Delta;::T, vsini::T, &#603;::T) where {T<:AbstractFloat}
     e1 = 2*(1 - &#603;)
     e2 = pi*&#603;/2
     e3 = pi*(1 - &#603;/3)
-    x1 = abs.(1 .- (vel ./ vsini) .^ 2)
+    x1 = abs.(T(1) .- (vel ./ vsini) .^ T(2)) # Use T(...) to work around https://github.com/JuliaLang/julia/issues/51129
     return vel, (e1 .* sqrt.(x1) .+ e2 .* x1) ./ e3
 end
 

-Original file line number
+Diff line change
     e1 = 2*(1 - ɛ)
     e2 = pi*ɛ/2
     e3 = pi*(1 - ɛ/3)
 -    x1 = abs.(1 .- (vel ./ vsini) .^ 2)
 +    x1 = abs.(T(1) .- (vel ./ vsini) .^ T(2)) # Use T(...) to work around https://github.com/JuliaLang/julia/issues/51129
     return vel, (e1 .* sqrt.(x1) .+ e2 .* x1) ./ e3
 end