Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: JakeChampion/fetch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.1
Choose a base ref
...
head repository: JakeChampion/fetch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.0
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Nov 10, 2016

  1. Change Headers multiple value handling for spec compatibility

    Consider this Headers object:
    
        var h = new Headers()
        h.append('accept', 'text/html')
        h.append('accept', 'text/plain')
        h.append('content-type', 'application/json')
    
    Before:
    
    - `h.get('accept')` returned `text/html`
    - `h.getAll('accept')` returned an array of values
    - `h.forEach` (and other iterables) did distinct iterations for each
      value of the same header
    
    Now:
    
    - `h.get('accept')` returns `text/html,text/plain`
    - `h.getAll()` is no more
    - `h.forEach` (and other iterables) now only do one iteration for each
      headers name, regardless of multiple values
    
    This is in accordance with Section 3.1.2 of the spec, "combine" concept.
    
    The updated tests currently break in Chrome and Firefox when exercising
    the native implementation because their implementation is outdated. The
    implementation in Edge is more correct, but the tests still fail there
    because its implementation combines values with `, ` (notice the space)
    rather than `,`.
    mislav committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    02b1dcb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    468f877 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2016

  1. Merge pull request #429 from mislav/headers-spec-compat

    Change Headers multiple value handling for spec compatibility
    mislav authored Nov 14, 2016
    Configuration menu
    Copy the full SHA
    fc226e8 View commit details
    Browse the repository at this point in the history
  2. fetch 2.0.0

    mislav committed Nov 14, 2016
    Configuration menu
    Copy the full SHA
    c576d61 View commit details
    Browse the repository at this point in the history
Loading