Fix: File listing after update.

pspoerri · pspoerri · commit c07c57c3ffe1 · 2024-04-10T08:49:03.000+02:00
Issue: Updates to files were not stored in the GEDS internal cache.
This resulted in invalid file listings.

To mitigate this issue the following changes were added:
- Updates are now reflected in the cache.
- The metadata server is always queried when the file status is
  requested.

Signed-off-by: Pascal Spo&#776;rri &lt;psp@zurich.ibm.com&gt;
diff --git a/src/libgeds/GEDS.cpp b/src/libgeds/GEDS.cpp
@@ -659,7 +659,7 @@ absl::StatusOr<GEDSFileStatus> GEDS::status(const std::string &bucket, const std
   }
 
   // Location is most likely a file.
-  auto obj = _metadataService.lookup(bucket, key);
+  auto obj = _metadataService.lookup(bucket, key, true /* invalidate */);
   if (obj.ok()) {
     return GEDSFileStatus{.key = key, .size = obj->info.size, .isDirectory = false};
   }
diff --git a/src/libgeds/MetadataService.cpp b/src/libgeds/MetadataService.cpp
@@ -249,6 +249,8 @@ absl::Status MetadataService::createObject(const geds::Object &obj) {
 absl::Status MetadataService::updateObject(const geds::Object &obj) {
   METADATASERVICE_CHECK_CONNECTED;
 
+  (void)_mdsCache.updateObject(obj);
+
   geds::rpc::Object request;
   auto id = request.mutable_id();
   id->set_bucket(obj.id.bucket);
@@ -508,4 +510,4 @@ absl::Status MetadataService::unsubscribe(const geds::SubscriptionEvent &event)
   return convertStatus(response);
 }
 
-} // namespace geds
+} // namespace geds

Original file line number	Diff line number	Diff line change
`@@ -659,7 +659,7 @@ absl::StatusOr<GEDSFileStatus> GEDS::status(const std::string &bucket, const std`
`659`	`659`	`}`
`660`	`660`
`661`	`661`	`// Location is most likely a file.`
`662`		`- auto obj = _metadataService.lookup(bucket, key);`
	`662`	`+ auto obj = _metadataService.lookup(bucket, key, true /* invalidate */);`
`663`	`663`	`if (obj.ok()) {`
`664`	`664`	`return GEDSFileStatus{.key = key, .size = obj->info.size, .isDirectory = false};`
`665`	`665`	`}`