slightly faster result logic

splitice · splitice · commit e1d58f69bfcd · 2025-09-24T13:32:09.000+10:00
diff --git a/packages/pg/lib/result.js b/packages/pg/lib/result.js
@@ -69,14 +69,11 @@ class Result {
   }
 
   parseRow(rowData) {
-    var row = { ...this._prebuiltEmptyResultObject }
-    for (var i = 0, len = rowData.length; i < len; i++) {
+    let row = { ...this._prebuiltEmptyResultObject }
+    for (let i = 0, len = rowData.length; i < len; i++) {
       var rawValue = rowData[i]
-      var field = this.fields[i].name
       if (rawValue !== null) {
-        row[field] = this._parsers[i](rawValue)
-      } else {
-        row[field] = null
+        row[this.fields[i].name] = this._parsers[i](rawValue)
       }
     }
     return row
@@ -108,7 +105,7 @@ class Result {
         this._parsers[i] = types.getTypeParser(desc.dataTypeID, desc.format || 'text')
       }
     }
-    this._prebuiltEmptyResultObject = { ...row }
+    this._prebuiltEmptyResultObject = row
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -69,14 +69,11 @@ class Result {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`parseRow(rowData) {`
`72`		`- var row = { ...this._prebuiltEmptyResultObject }`
`73`		`- for (var i = 0, len = rowData.length; i < len; i++) {`
	`72`	`+ let row = { ...this._prebuiltEmptyResultObject }`
	`73`	`+ for (let i = 0, len = rowData.length; i < len; i++) {`
`74`	`74`	`var rawValue = rowData[i]`
`75`		`- var field = this.fields[i].name`
`76`	`75`	`if (rawValue !== null) {`
`77`		`- row[field] = this._parsers[i](rawValue)`
`78`		`- } else {`
`79`		`- row[field] = null`
	`76`	`+ row[this.fields[i].name] = this._parsers[i](rawValue)`
`80`	`77`	`}`
`81`	`78`	`}`
`82`	`79`	`return row`
`@@ -108,7 +105,7 @@ class Result {`
`108`	`105`	`this._parsers[i] = types.getTypeParser(desc.dataTypeID, desc.format \|\| 'text')`
`109`	`106`	`}`
`110`	`107`	`}`
`111`		`- this._prebuiltEmptyResultObject = { ...row }`
	`108`	`+ this._prebuiltEmptyResultObject = row`
`112`	`109`	`}`
`113`	`110`	`}`
`114`	`111`