Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Experience Details Page #30

Merged
merged 9 commits into from
Nov 7, 2023
Merged

Conversation

NitBravoA92
Copy link
Collaborator

@NitBravoA92 NitBravoA92 commented Nov 7, 2023

🚩Experience Details page

Hi @AndreaM2429

I'm sending this pull request for you to review my code. Thanks in advance for your feedback!

Milestones 🎯:

📌 Generate the ExperienceDetails.js, and added to the src/Components folder

📌 Generate the ExperienceIncluded.js, and added to the src/Components folder

📌 Create the helper method: getRandomDiscount() to generate a random discount

📌 Get the selected experience data from the store using the experienceID and display it on the Experience Details page

📌 Update the App.js file to include the new CSS styles and the ExperienceDetails component

📌 Update the main title of the App in the index.html file

📌 Create the CSS styles to match the original design as closely as possible.

📌 Update the code in the files: RoutesWrapper.js, usersSlice.js, MainPage.jsx and ReservationForm to fix some bugs in the process of loading the pages

⭐To the code reviewer 👨‍💻

Please, I kindly ask you to review the entire code and verify that all requirements have been met correctly.
if there is any issue 🦯 in this PR, please do list 📃 them in a descriptive 💡 manner and give your best suggestions 🎁 if needed.

@NitBravoA92 NitBravoA92 added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 7, 2023
@NitBravoA92 NitBravoA92 self-assigned this Nov 7, 2023
@NitBravoA92 NitBravoA92 linked an issue Nov 7, 2023 that may be closed by this pull request
Copy link
Collaborator

@AndreaM2429 AndreaM2429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Status: Approved 🟢

Hi @NitBravoA92

Great work on implementing the new feature, this is complete so it's time to merge it 💯 🥳.

congrats

Highlights 🥇

  • Linters running
  • The app works as expected
  • Good and clean design

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval. Still, I would highly recommend that you consider these changes.

Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Remember to tag me in your question so I can receive the notification.

<div className="w-100">
<div className="experience-details w-100">
<div className="experience-image w-100">
<img src={selectedExperience?.image} alt={selectedExperience?.name} className="fluid-img" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Optional] I recommended you decrease the size of the image on the desktop version, to 768px and consider blocking the size at 600px.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreaM2429 Thank you very much for taking the time to review my PR and suggesting these valuable changes. They have been added.

@NitBravoA92 NitBravoA92 merged commit e6ae783 into dev Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[4.5pt] - Add Experience details page
2 participants