Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Onboard gnomAD dataset #264

Merged
merged 5 commits into from
Jan 27, 2022
Merged

feat: Onboard gnomAD dataset #264

merged 5 commits into from
Jan 27, 2022

Conversation

happyhuman
Copy link
Contributor

@happyhuman happyhuman commented Jan 7, 2022

Description

Dataset name: gnomad
Pipeline name: gnomad.copy_gcs_bucket

Checklist

  • Please merge this PR for me once it is approved.
  • If this PR adds or edits a dataset or pipeline, it was reviewed and approved by the Google Cloud Public Datasets team beforehand.
  • If this PR adds or edits a dataset or pipeline, I put all my code inside datasets/<YOUR-DATASET> and nothing outside of that directory.
  • This PR is appropriately labeled.

@adlersantos adlersantos self-requested a review January 10, 2022 17:36
@adlersantos adlersantos added the data onboarding Onboard a dataset or submit a pipeline label Jan 10, 2022
@adlersantos adlersantos changed the title Gnomad feat: Onboard gnomAD dataset Jan 10, 2022
Copy link
Member

@adlersantos adlersantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change plus the linter errors and we should be good to go!

project_id: bigquery-public-data
source_bucket: "gnomad-public-requester-pays"
destination_bucket: "gcp-public-data--gnomad"
google_impersonation_chain: "{{ var.json.gnomad.service_account }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add an additional parameter under args so we keep all files historically:

transfer_options:
  deleteObjectsUniqueInSink: False

@adlersantos adlersantos merged commit 804b440 into main Jan 27, 2022
@adlersantos adlersantos deleted the gnomad branch January 27, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data onboarding Onboard a dataset or submit a pipeline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants