Add PortForward to runtime API. #7391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/kubelet/container/runtime.go
Outdated
Contributor
There was a problem hiding this comment.
I found the current implementation takes a *kubecontainer.Pod. But that's the identical. Both work :)
Contributor
Author
There was a problem hiding this comment.
That's a good point. We need to standardize on one or the other. Right now everything in the interface takes api.Pod even when it doesn't need to. We can start with this one.
Changed it to Pod.
vmarmol
force-pushed
the
rkt-portforward
branch
from
82b04e0 to
3a61421
Compare
Member
|
LGTM. Are we going to implement PortForward to rkt support now? |
Contributor
|
@dchen1107 I think I can implement that. It's almost the same as the docker one. We just need the pid for the "pod", which is available via |
Member
|
SGTM. Will merge it once it is green. |
Contributor
Author
|
Travis is green! (finally...) |
dchen1107
added a commit
that referenced
this pull request
Apr 28, 2015
Add PortForward to runtime API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dchen1107 @yifan-gu