API Conventions for Late-initializers #7366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Late-initializers should only make the following types of modifications: | ||
| - Setting previously unset fields | ||
| - Adding keys to maps | ||
| - Adding values to arrays which have mergeable semantics (mergePatch attribute in go definition of type). |
|
LGTM. Thanks much. |
bgrant0607
added a commit
that referenced
this pull request
Apr 28, 2015
API Conventions for Late-initializers
|
This is helpful to lay out. Agree with the admission control comments for those handlers that modify incoming objects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formalizing what @bgrant0607 and I discussed in the context of the SecurityContext changes.