Skip to content

Conversation

@pmorie
Copy link
Contributor

@pmorie pmorie commented Apr 27, 2015

@zmerlynn PTAL

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@pmorie
Copy link
Contributor Author

pmorie commented Apr 27, 2015

kicked shippable

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expectNoError(err)

@pmorie
Copy link
Contributor Author

pmorie commented Apr 27, 2015

@zmerlynn fixed

@zmerlynn zmerlynn added cla: yes lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: no labels Apr 27, 2015
@zmerlynn
Copy link
Member

LGTM

@zmerlynn
Copy link
Member

Will merge on green.

@pmorie
Copy link
Contributor Author

pmorie commented Apr 27, 2015

@zmerlynn Light is green, trap is clean

zmerlynn added a commit that referenced this pull request Apr 27, 2015
Parity for namespace handling in secrets E2E
@zmerlynn zmerlynn merged commit 800739a into kubernetes:master Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants