Skip to content

Updating the guestbook example to v1beta3 #7194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bgrant0607 merged 1 commit into from
Apr 23, 2015
Merged

Updating the guestbook example to v1beta3 #7194

bgrant0607 merged 1 commit into from
Apr 23, 2015

Conversation

@nikhiljindal
Copy link
Contributor

@nikhiljindal nikhiljindal commented Apr 22, 2015

For #6584

@roberthbailey
Copy link
Contributor

roberthbailey commented Apr 22, 2015

@briandorsey FYI

@nikhiljindal
Copy link
Contributor Author

nikhiljindal commented Apr 22, 2015

Fixing tests

@nikhiljindal nikhiljindal force-pushed the example branch 2 times, most recently from ee640e3 to 888e44a Compare April 23, 2015 00:47
@nikhiljindal
Copy link
Contributor Author

nikhiljindal commented Apr 23, 2015

Tests fixed!

@wojtek-t
Copy link
Member

wojtek-t commented Apr 23, 2015

cc @piosz

bgrant0607
bgrant0607 reviewed Apr 23, 2015
View reviewed changes
examples/guestbook/README.md Outdated
Copy link
Member

@bgrant0607 bgrant0607 Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make v1beta3 the primary text and older APIs in paretheses.

Copy link
Member

@bgrant0607 bgrant0607 Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or remove mention of the old fields entirely, since we're removing the old example, anyway.

Copy link
Contributor Author

@nikhiljindal nikhiljindal Apr 23, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bgrant0607
Copy link
Member

bgrant0607 commented Apr 23, 2015

One minor comment. Otherwise LGTM. Thanks!

@bgrant0607
Copy link
Member

bgrant0607 commented Apr 23, 2015

LGTM

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2015
bgrant0607 added a commit that referenced this pull request Apr 23, 2015
@bgrant0607
Merge pull request #7194 from nikhiljindal/example
38ea531 
Updating the guestbook example to v1beta3
@bgrant0607 bgrant0607 merged commit 38ea531 into kubernetes:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bgrant0607 bgrant0607

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikhiljindal @roberthbailey @wojtek-t @bgrant0607 @googlebot