Skip to content

Conversation

@pmorie
Copy link
Contributor

@pmorie pmorie commented Apr 22, 2015

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to create a file in the path that containers can access. Is that really what you intended? What if I create a secret named "ready"?

@thockin
Copy link
Member

thockin commented Apr 22, 2015

LGTM but the one question - I suspect you want to mimic gitrepo here

@pmorie
Copy link
Contributor Author

pmorie commented Apr 23, 2015

@thockin I see on closer inspection that the git repo plugin uses the
PodPluginDir to store the ready file, which isn't exposed to the user.
Will refactor to use that.

On Wed, Apr 22, 2015 at 7:32 PM, Tim Hockin [email protected]
wrote:

LGTM but the one question - I suspect you want to mimic gitrepo here


Reply to this email directly or view it on GitHub
#7166 (comment)
.

@pmorie pmorie force-pushed the secrets-idempotent branch from a7ef6c1 to bc8f010 Compare April 23, 2015 15:23
@pmorie
Copy link
Contributor Author

pmorie commented Apr 23, 2015

@thockin The ready file isn't exposed to the user now.

thockin added a commit that referenced this pull request Apr 23, 2015
Make secret volume plugin idempotent
@thockin thockin merged commit 4e40423 into kubernetes:master Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants