Skip to content

Conversation

@ravigadde
Copy link
Contributor

Added a field selector for listing pods

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@ravigadde
Copy link
Contributor Author

I authored the commits.

On Mon, Apr 20, 2015 at 1:33 PM, googlebot [email protected] wrote:

We found a Contributor License Agreement for you (the sender of this pull
request) and all commit authors, but as best as we can tell these commits
were authored by someone else. If that's the case, please add them to this
pull request and have them confirm that they're okay with these commits
being contributed to Google. If we're mistaken and you did author these
commits, just reply here to confirm.


Reply to this email directly or view it on GitHub
#7067 (comment)
.

@brendandburns
Copy link
Contributor

You need to sign the CLA, details in CONTRIBUTING.md

@brendandburns
Copy link
Contributor

This LGTM, modulo getting the CLA signed.

@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 20, 2015
@ravigadde
Copy link
Contributor Author

@brendanburns I think there is some confusion between individual and corporate CLAs. I had originally signed an individual CLA. After signing the corporate CLA, I started seeing this error. I have now added my corporate email to my github account. Hope that helps.

@googlebot
Copy link

CLAs look good, thanks!

@fgrzadkowski
Copy link
Contributor

LGTM.

Can you please look into travis/shippable failures?

@ravigadde
Copy link
Contributor Author

Fixed the travis issue. Can anyone tell me what the shippable failure is? I cant see it.

@fgrzadkowski
Copy link
Contributor

F0421 13:48:12.847654 3342 integration.go:393] static-pod-from-manifest FAILED: mirror pod has not been created or is not running: timed out waiting for the condition
!!! Error in ./hack/test-integration.sh:47
'"${KUBE_OUTPUT_HOSTBIN}/integration" --v=2 --apiVersion="$1" --maxConcurrency="${KUBE_INTEGRATION_TEST_MAX_CONCURRENCY}"' exited with status 255
Call stack:
1: ./hack/test-integration.sh:47 runTests(...)
2: ./hack/test-integration.sh:61 main(...)
Exiting with status 1

bgrant0607 added a commit that referenced this pull request Apr 22, 2015
Added field selector for listing pods
@bgrant0607 bgrant0607 merged commit 15c2986 into kubernetes:master Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants