Move the logging-related directories to where I think they belong #7014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move fluentd-gcp to be a core cluster addon, rather than a contrib. 2. Get rid of the synthetic logger under contrib, since the exact same synthetic logger was also included in the logging-demo. 3. Move the logging-demo to examples, since it's effectively an example. We should also consider adding on a GCP section to the logging-demo example :)
|
I thought about doing this in the past, but one reason I hesitated is that GCP cluster level logging is not an "add on" in the same way that Elasticsearch logging is. |
satnam6502
added
the
lgtm
|
I'm guessing you mean that in the sense that it doesn't run as actual pods that the apiserver knows about? Would you suggest somewhere more appropriate? My two thoughts are that it makes sense to keep it in the same place as the fluentd-es image and that "contrib" makes it seem unsupported, whereas we do want it to be supported. |
|
I was also thinking of doing what exactly what you did since logically it makes some sense for them to be close to the Elasticsearch versions and I felt uncomfortable about languishing in the contrib directory. |
brendandburns
added a commit
that referenced
this pull request
Apr 20, 2015
Move the logging-related directories to where I think they belong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
synthetic logger was also included in the logging-demo.
We should also consider adding on a GCP section to the logging-demo
example :)
cc @satnam6502