Prioritize deleting the non-running pods when reducing replicas #6992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Unassigned < assigned | ||
| if s[i].Spec.Host == "" && s[j].Spec.Host != "" { | ||
| return true | ||
| } |
There was a problem hiding this comment.
This is great. You could also check readiness (not ready < ready). The endpoints controller check could be factored out into a function:
https://github.com/GoogleCloudPlatform/kubernetes/blob/e1b76b922b3f7aec73715cc53cb6f8e9180e5c26/pkg/service/endpoints_controller.go#L99
There was a problem hiding this comment.
Factored out the pod ready logic to api.IsPodReady. Added this new condition to pod sorting.
yujuhong
force-pushed
the
kill_pods
branch
2 times, most recently
from
3fa44ac to
dd4527a
Compare
|
Comments addressed in the new patch. Thanks for the suggestion! |
|
|
||
| func (s activePods) Less(i, j int) bool { | ||
| // Not ready < ready | ||
| if !api.IsPodReady(&s[i]) && api.IsPodReady(&s[j]) { |
There was a problem hiding this comment.
I would order the checks as follows:
- host
- phase
- readiness
but it shouldn't make a lot of difference.
|
LGTM |
bgrant0607
added
the
lgtm
This changes instructs the replication controller to delete replicas in the order of "unscheduled (pending)", "scheduled (pending)", and "scheduled (running)" pods. This is less disruptive than deleting random pods.
|
Addressed the comments and rebased. |
|
Thanks. LGTM. |
bgrant0607
added a commit
that referenced
this pull request
Apr 21, 2015
Prioritize deleting the non-running pods when reducing replicas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes instructs the replication controller to delete replicas in the
order of "unscheduled (pending)", "scheduled (pending)", and "scheduled
(running)" pods. This is less disruptive than deleting random pods.
This fixes #3948.