Use narrowly scoped interfaces for client access #6871
Conversation
Use custom narrowly scoped interfaces for client access from the RollingUpdater and Resizer. This allows for more flexible downstream integration and unit testing without imposing a burden to implement the entire client.Interface for just a handful of methods.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
There was a problem hiding this comment.
FTR I think this is a pattern we should apply more.
Edit: specifically defining local-ish interfaces that implement JUST what we need in the local module.
There was a problem hiding this comment.
Agreed, let's drop the hammer on anyone who even looks at *client.Client funny
|
@thockin @pmorie @smarterclayton bd7b719 introduces some constructors which allow us to keep the |
|
I see how it works. You drive-by some comments and BAM, you get assigned the code review. That'll teach me. LGTM |
Use narrowly scoped interfaces for client access
|
You must be new here.
|
5 participants
Use custom narrowly scoped interfaces for client access from the
RollingUpdater and Resizer. This allows for more flexible downstream
integration and unit testing without imposing a burden to implement
the entire client.Interface for just a handful of methods.