Skip to content

Tighten label parsing #6674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bgrant0607 merged 1 commit into from
Apr 23, 2015
Merged

Tighten label parsing #6674

bgrant0607 merged 1 commit into from
Apr 23, 2015

Conversation

@0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Apr 10, 2015

I was wondering if there is any reason ParseLabels deliberately doesn't error on invalid label specs. Is there any?

@jszczepkowski
Copy link
Contributor

jszczepkowski commented Apr 10, 2015

LGTM for me.

@brendanburns is there any reason to ignore parse errors in labels?

@0xmichalis
Copy link
Contributor Author

0xmichalis commented Apr 14, 2015

@brendandburns ping

@bgrant0607
Copy link
Member

bgrant0607 commented Apr 23, 2015

LGTM.

bgrant0607 added a commit that referenced this pull request Apr 23, 2015
@bgrant0607
Merge pull request #6674 from kargakis/error-on-invalid-label-spec
24cad22 
Tighten label parsing
@bgrant0607 bgrant0607 merged commit 24cad22 into kubernetes:master Apr 23, 2015
@0xmichalis 0xmichalis deleted the error-on-invalid-label-spec branch April 24, 2015 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@0xmichalis @jszczepkowski @bgrant0607 @brendanburns @googlebot @Kargakis