feat: HACKATHON Kill Civil Time #2018
Draft
+122
−168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renames some for clarity as well
Deploying atlantis with
|
| Latest commit: |
f5390e7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://eccd2206.atlantis.pages.dev |
| Branch Preview URL: | https://jeffm-hackathon-kill-civil-t.atlantis.pages.dev |
includes notes on naming influenced by x-mui adapter layer
JeffMarvin
force-pushed
the
JEFFM/hackathon-kill-civil-time
branch
3 times, most recently
from
2b502a1 to
94e106c
Compare
fixup inputtime f
JeffMarvin
force-pushed
the
JEFFM/hackathon-kill-civil-time
branch
from
94e106c to
82d9a2c
Compare
|
Published Pre-release for f5390e7 with versions: To install the new version(s) for Web run: |
JeffMarvin
commented
Sep 21, 2024
| const currentDate = new Date(); | ||
| const currentYear = currentDate.getFullYear(); | ||
| const currentMonth = currentDate.getMonth(); | ||
| const currentDay = currentDate.getDay(); |
There was a problem hiding this comment.
Not that it affected the time part of this, but getDay is a bug. getDate() will return the numeric day of the month, getDay returns the day of the week indexed from 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations
Changes
Added
Changed
Deprecated
Removed
Fixed
Security
Testing
Changes can be
tested via Pre-release
In Atlantis we use Github's built in pull request reviews.