Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly denote classes as Stringable #81

Closed
wants to merge 2 commits into from

Conversation

fox34
Copy link

@fox34 fox34 commented Nov 29, 2023

Explicitly denote classes that implement __toString as Stringable (as suggested by the official PHP docs), which helps IDEs to check type safety.

@ChadSikorra
Copy link
Contributor

Hi 👋 Thanks for taking the time to open this PR! I've actually implemented this change on the 1.0 branch. However, this year has been a bit of a disaster from a work perspective and I haven't finalized that branch. I think I want to keep the changes in current master to bug fix only, as the next release will be the 1.0 branch.

@fox34 fox34 closed this by deleting the head repository Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants