Missing LDAP-style case insensitive search in Entries #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if it should be named like this, but I was missing LDAP-style case insensitive search in Entries. Maybe use mb_strtolower ? Or an LDAP spec strtolower() implementation.. ? I'm not even sure if I would merge this as is 😅
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #41 +/- ##
============================================
- Coverage 89.71% 89.43% -0.28%
- Complexity 1780 1788 +8
============================================
Files 115 115
Lines 3850 3862 +12
============================================
Hits 3454 3454
- Misses 396 408 +12 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it should be named like this, but I was missing LDAP-style case insensitive search in Entries.
Maybe use mb_strtolower ? Or an LDAP spec strtolower() implementation.. ?
I'm not even sure if I would merge this as is 😅