Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] TechDraw circle centerlines aren't recomputed. <Exception> Dimension Reference has null geometry #9953

Open
2 tasks done
vladtcvs opened this issue Jul 18, 2023 · 14 comments
Labels
Mod: TechDraw Related to the TechDraw Workbench Status: Needs feedback Missing required feedback from user or dev Status: Stale Stale and might be closed automatically. Type: Bug This issue or PR is related to a bug

Comments

@vladtcvs
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Version

0.20 (Release)

Full version info

[code]
OS: Debian GNU/Linux trixie/sid (KDE/plasma)
Word size of FreeCAD: 64-bit
Version: 0.20.2.
Build type: Release
Python 3.11.4, Qt 5.15.8, Coin 4.0.0, Vtk 9.1.0, OCC 7.6.3
Locale: English/United States (en_US)
[/code]

Subproject(s) affected?

None

Problem description

Steps to reproduce:

  1. Add circle centerlines for some arc
  2. Change arc center
  3. Centerlines don't change their position

image

On this example centerlines should be in the center of arc, which has radius specified

Anything else?

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@luzpaz luzpaz added the Status: Needs test on dev version Missing test on the weekly version label Jul 18, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Jul 18, 2023

Please try to reproduce on development build (https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds) and report back. TIA

@WandererFan
Copy link
Contributor

Are you using https://wiki.freecad.org/TechDraw_ExtensionCircleCenterLines?
I don't think that function is smart enough to know that the circle has changed. It just creates a cosmetic edge based on the circle geometry at creation time.
@edi271 any comments?

@vladtcvs
Copy link
Author

vladtcvs commented Jul 18, 2023

@vladtcvs
Copy link
Author

vladtcvs commented Jul 18, 2023

Please try to reproduce on development build (https://github.com/FreeCAD/FreeCAD-Bundle/releases/tag/weekly-builds) and report back. TIA

The same result
image

@Roy-043 Roy-043 added the Mod: TechDraw Related to the TechDraw Workbench label Jul 18, 2023
@edi271
Copy link
Contributor

edi271 commented Jul 25, 2023

Are you using https://wiki.freecad.org/TechDraw_ExtensionCircleCenterLines? I don't think that function is smart enough to know that the circle has changed. It just creates a cosmetic edge based on the circle geometry at creation time. @edi271 any comments?

Correct. I don't know any method to change a cosmetic line. For example the extend/shorten line tool deletes the old line and creates a new one.

@luzpaz luzpaz added the Status: Needs feedback Missing required feedback from user or dev label Jul 25, 2023
@luzpaz luzpaz changed the title [Problem] Circle centerlines don't recomputed [Problem] TechDraw circle centerlines aren't recomputed Aug 16, 2023
@luzpaz luzpaz removed the Status: Needs test on dev version Missing test on the weekly version label Aug 16, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Aug 16, 2023

@WandererFan is this a feature request then ?

@luzpaz
Copy link
Contributor

luzpaz commented Sep 7, 2023

@WandererFan ping

@WandererFan
Copy link
Contributor

on the list....
...
- hatching is only on 1 face? there was a fix for this *** fixed

@luzpaz luzpaz added the Type: Bug This issue or PR is related to a bug label Sep 10, 2023
@fra589
Copy link
Contributor

fra589 commented Oct 30, 2023

Same problem on my dev version discussed here: https://forum.freecad.org/viewtopic.php?t=82182

With Segmentation fault crash on Version: 0.22.0dev.34523 (Git)

No crash on version 0.22.0dev.34789 (Git), but error messages:

DVP::getProjVertexByIndex(11) - invalid index
DVP::getProjVertexByIndex(13) - invalid index
CL::scaledGeometry - failed to calculate endpoints!
CE::addCenterLinesToGeom - scaledGeometry is null
DVP::getProjVertexByIndex(12) - invalid index
CL::scaledGeometry - failed to calculate endpoints!
CE::addCenterLinesToGeom - scaledGeometry is null
<Exception> Dimension Reference has null geometry
<Exception> Dimension Reference has null geometry

When moving the circle object reference.

@++;
Gauthier.

@luzpaz luzpaz changed the title [Problem] TechDraw circle centerlines aren't recomputed [Problem] TechDraw circle centerlines aren't recomputed. <Exception> Dimension Reference has null geometry Nov 17, 2023
@luzpaz
Copy link
Contributor

luzpaz commented Nov 17, 2023

@WandererFan what is the proposed fix here. Perhaps another dev would step up with a fix if they were provided orientation ?

@WandererFan
Copy link
Contributor

In general, the functions in CommandExtensionPack just draw things based on the current state of the model. They don't participate in the normal recompute cascade or remember the parameters used at creation time.

We'd need a new document object created that would have properties to remember that a centre line was created for a given circle (view+geometry element) and update itself when the view that owns the circle changes. Since the circle is a subelement of the view, the toponaming exposure is significant, and the object would need all the reference checking and repair functionality that is in DrawViewDimension.

The problem statement sounds like all that is needed is to insert a line of code somewhere that calls recompute(). In fact, this (and a number of other Extension related tickets, like face area) needs significant changes.

@luzpaz
Copy link
Contributor

luzpaz commented Nov 30, 2023

Looks related to downstream arch bug: https://bugs.archlinux.org/task/73944

Steps to reproduce:

  1. Open FreeCAD from the repos
  2. Open e.g. the attached demo file
  3. Note how in the TechDraw page, there are no arc center marks even though they are set to be visible.
    Example file: https://bugs.archlinux.org/task/73944?getfile=21228

@WandererFan
Copy link
Contributor

The center lines drawn by the extension pack are not related to the center marks that are attached to every circle/arc. The center marks are the ones that don't appear in some linux versions.

Copy link

github-actions bot commented Jan 6, 2025

Hi! This issue hasn’t seen activity in a while. We automatically check each issue after 190 days without activity to keep the backlog tidy.
If it’s still relevant, please update to the latest FreeCAD weekly build download here to see if the issue is already resolved.

If the issue is still relevant, let us know by adding a comment.
Otherwise, we’ll close this issue automatically in 60 days.

Feel free to comment anytime to keep it open. Closed issues can always be reopened.
Thanks for helping improve FreeCAD!

Access additional FreeCAD resources:

@github-actions github-actions bot added the Status: Stale Stale and might be closed automatically. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: TechDraw Related to the TechDraw Workbench Status: Needs feedback Missing required feedback from user or dev Status: Stale Stale and might be closed automatically. Type: Bug This issue or PR is related to a bug
Projects
None yet
Development

No branches or pull requests

6 participants