Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Draft: Draft_Offset has multiple issues #10435

Open
Roy-043 opened this issue Aug 30, 2023 · 1 comment
Open

[Problem] Draft: Draft_Offset has multiple issues #10435

Roy-043 opened this issue Aug 30, 2023 · 1 comment
Labels
3rd party: OCC Mod: Draft Related to the Draft Workbench Status: Confirmed The issue was confirmed by others Type: Bug This issue or PR is related to a bug

Comments

@Roy-043
Copy link
Contributor

Roy-043 commented Aug 30, 2023

Draft_Offset has multiple issues:

  1. User has to move the cursor to the correct side of the object in the 3D view before entering an offset value in the task panel.
  2. When entering that value the mouse may accidentally move resulting in a new offset value.
  3. OCC style offset fails for single lines. Cause: lines do not define a plane. There is a confusing error message. This should be prevented. Forum topic: https://forum.freecad.org/viewtopic.php?t=80775.
  4. OCC style offset fails for arcs. Cause: offsets.offsetWire receives wrong argument type (float instead of vector). There is a confusing error message.
  5. The OCC style offset checkbox is ignored for B-splines if a point is clicked in the 3D view.
  6. If a distance is specified in the task panel, OCC style offset fails for B-splines. Cause: offsets.offsetWire receives wrong argument type (list of vectors instead of vector). There is a confusing error message.
  7. Offsetting B-splines does not result in a 'true' offset. Their points are offset, and a new spline is constructed based on them.
  8. The point indicated in the 3D view is not projected on the offset plane.

Using the makeOffset2D method inside offsets.offsetWire may be the way to go. The method can create an OCC style offset but also a single offset. The shape produced by makeOffset2D would then have to be 'Draftified'. OCC style offsets for single lines would require dedicated code (using the Draft WorkingPlane as a reference for the offset plane).

Version info:

OS: Windows 8 build 9600
Word size of FreeCAD: 64-bit
Version: 0.22.0dev.33981 (Git)
Build type: Release
Branch: master
Hash: 5a153e50ffb6046b6cc4dba498344032f6edb952
Python 3.10.12, Qt 5.15.8, Coin 4.0.0, Vtk 9.2.5, OCC 7.6.3
Locale: Dutch/Netherlands (nl_NL)
Installed mods:
@Roy-043 Roy-043 added Type: Bug This issue or PR is related to a bug Mod: Draft Related to the Draft Workbench labels Aug 30, 2023
@Roy-043 Roy-043 changed the title Draft: Draft_Offset: avoid OCC offset problems or handle them more gracefully Draft: Draft_Offset has multiple issues Sep 1, 2023
@luzpaz luzpaz changed the title Draft: Draft_Offset has multiple issues [Problem] Draft: Draft_Offset has multiple issues Nov 8, 2023
@semhustej
Copy link

I encountered another small problem:

When trying to create Draft_Offset of ellipse, the report view informs user that DraftGeomUtils: Couldn't project point multiple times.
ellipse

The proposed solution is to inform the user:
Offset of this object type is not supported.


When trying to create Draft_Offset of point, there is no information in the report view.

The proposed solution is to inform the user:
Offset of this object type is not supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party: OCC Mod: Draft Related to the Draft Workbench Status: Confirmed The issue was confirmed by others Type: Bug This issue or PR is related to a bug
Projects
None yet
Development

No branches or pull requests

3 participants