add delay to reading deletion and always show toggles

gabrielburnworth · gabrielburnworth · commit 38d47a74cffc · 2025-11-21T10:31:01.000-08:00
diff --git a/frontend/css/panels/sensors.scss b/frontend/css/panels/sensors.scss
@@ -20,6 +20,8 @@
   font-size: 1.2rem;
   background: $translucent1_white;
   border-radius: 0.5rem;
+  max-height: 50rem;
+  overflow: scroll;
   th,
   td {
     width: 1%;
diff --git a/frontend/farm_designer/index.tsx b/frontend/farm_designer/index.tsx
@@ -188,7 +188,6 @@ export class RawFarmDesigner
         showZones={show_zones}
         showSensorReadings={show_sensor_readings}
         showMoistureInterpolationMap={show_moisture_interpolation_map}
-        hasSensorReadings={this.props.sensorReadings.length > 0}
         dispatch={this.props.dispatch}
         timeSettings={this.props.timeSettings}
         getConfigValue={this.props.getConfigValue}
diff --git a/frontend/farm_designer/map/interfaces.ts b/frontend/farm_designer/map/interfaces.ts
@@ -53,7 +53,6 @@ export interface GardenMapLegendProps {
   showZones: boolean;
   showSensorReadings: boolean;
   showMoistureInterpolationMap: boolean;
-  hasSensorReadings: boolean;
   dispatch: Function;
   timeSettings: TimeSettings;
   getConfigValue: GetWebAppConfigValue;
diff --git a/frontend/farm_designer/map/legend/__tests__/garden_map_legend_test.tsx b/frontend/farm_designer/map/legend/__tests__/garden_map_legend_test.tsx
@@ -45,7 +45,6 @@ describe("<GardenMapLegend />", () => {
     showZones: false,
     showSensorReadings: false,
     showMoistureInterpolationMap: false,
-    hasSensorReadings: false,
     dispatch: jest.fn(),
     timeSettings: fakeTimeSettings(),
     getConfigValue: jest.fn(),
@@ -69,7 +68,6 @@ describe("<GardenMapLegend />", () => {
 
   it("renders with readings", () => {
     const p = fakeProps();
-    p.hasSensorReadings = true;
     const wrapper = mount(<GardenMapLegend {...p} />);
     expect(wrapper.text().toLowerCase()).toContain("readings");
   });
diff --git a/frontend/farm_designer/map/legend/garden_map_legend.tsx b/frontend/farm_designer/map/legend/garden_map_legend.tsx
@@ -203,18 +203,16 @@ const LayerToggles = (props: LayerTogglesProps) => {
       value={props.showZones}
       label={DeviceSetting.showAreas}
       onClick={toggle(BooleanSetting.show_zones)} />
-    {props.hasSensorReadings &&
-      <LayerToggle
-        settingName={BooleanSetting.show_sensor_readings}
-        value={props.showSensorReadings}
-        label={DeviceSetting.showReadings}
-        onClick={toggle(BooleanSetting.show_sensor_readings)} />}
-    {props.hasSensorReadings &&
-      <LayerToggle
-        settingName={BooleanSetting.show_moisture_interpolation_map}
-        value={props.showMoistureInterpolationMap}
-        label={DeviceSetting.showMoisture}
-        onClick={toggle(BooleanSetting.show_moisture_interpolation_map)} />}
+    <LayerToggle
+      settingName={BooleanSetting.show_sensor_readings}
+      value={props.showSensorReadings}
+      label={DeviceSetting.showReadings}
+      onClick={toggle(BooleanSetting.show_sensor_readings)} />
+    <LayerToggle
+      settingName={BooleanSetting.show_moisture_interpolation_map}
+      value={props.showMoistureInterpolationMap}
+      label={DeviceSetting.showMoisture}
+      onClick={toggle(BooleanSetting.show_moisture_interpolation_map)} />
   </div>;
 };
 
diff --git a/frontend/sensors/sensor_readings/__tests__/sensor_readings_test.tsx b/frontend/sensors/sensor_readings/__tests__/sensor_readings_test.tsx
@@ -12,6 +12,7 @@ import {
 } from "../../../__test_support__/fake_state/resources";
 import { fakeTimeSettings } from "../../../__test_support__/fake_time_settings";
 import { destroy } from "../../../api/crud";
+import { busy } from "../../../toast/toast";
 
 describe("<SensorReadings />", () => {
   const fakeProps = (): SensorReadingsProps => ({
@@ -105,22 +106,27 @@ describe("<SensorReadings />", () => {
   });
 
   it("deletes selected readings", () => {
+    jest.useFakeTimers();
     window.confirm = () => true;
     const p = fakeProps();
     const wrapper = mount<SensorReadings>(<SensorReadings {...p} />);
     const reading = fakeSensorReading();
     reading.uuid = "uuid0";
     wrapper.instance().deleteSelected([reading])();
+    jest.runAllTimers();
     expect(destroy).toHaveBeenCalledWith("uuid0");
+    expect(busy).toHaveBeenCalledWith("Deleting 1 sensor readings...");
   });
 
   it("doesn't delete selected readings", () => {
+    jest.useFakeTimers();
     window.confirm = () => false;
     const p = fakeProps();
     const wrapper = mount<SensorReadings>(<SensorReadings {...p} />);
     const reading = fakeSensorReading();
     reading.uuid = "uuid0";
     wrapper.instance().deleteSelected([reading])();
+    jest.runAllTimers();
     expect(destroy).not.toHaveBeenCalled();
   });
 });
diff --git a/frontend/sensors/sensor_readings/sensor_readings.tsx b/frontend/sensors/sensor_readings/sensor_readings.tsx
@@ -15,6 +15,7 @@ import { SensorReadingsPlot } from "./graph";
 import { Position } from "@blueprintjs/core";
 import { AddSensorReadingMenu } from "./add_reading";
 import { destroy } from "../../api/crud";
+import { busy } from "../../toast/toast";
 
 export class SensorReadings
   extends React.Component<SensorReadingsProps, SensorReadingsState> {
@@ -51,7 +52,10 @@ export class SensorReadings
     if (!confirm(t("Delete {{count}} sensor readings?", {
       count: readings.length,
     }))) { return; }
-    readings.map(reading => this.props.dispatch(destroy(reading.uuid)));
+    busy(t("Deleting {{count}} sensor readings...", { count: readings.length }));
+    readings.map((reading, index) => {
+      setTimeout(() => this.props.dispatch(destroy(reading.uuid)), index * 250);
+    });
   };
 
   toggleAddReadingMenu = () => {
