Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composer(deps): bump friendsofphp/php-cs-fixer from 2.18.6 to 3.0.0 in /vendor-bin/php-cs-fixer #330

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Jun 1, 2021

Bumps friendsofphp/php-cs-fixer from 2.18.6 to 3.0.0.

Release notes

Sourced from friendsofphp/php-cs-fixer's releases.

v3.0.0 Constitution

The easiest way to update from v2.x is:

  • install v2.19 and run in verbose mode (php-cs-fixer fix -v) or in future mode (PHP_CS_FIXER_FUTURE_MODE=1 php-cs-fixer fix) to identify and fix deprecations
  • install v3.0 and follow upgrade guide

  • bug #5164 Differ - surround file name with double quotes if it contains spacing. (SpacePossum)
  • bug #5560 PSR2: require visibility only for properties and methods (kubawerlos)
  • bug #5576 ClassAttributesSeparationFixer: do not allow using v2 config (kubawerlos)
  • feature #4979 Pass file to differ (paulhenri-l, SpacePossum)
  • minor #3374 show-progress option: drop run-in and estimating, rename estimating-max to dots (keradus)
  • minor #3375 Fixers - stop exposing extra properties/consts (keradus)
  • minor #3376 Tokenizer - remove deprecations and legacy mode (keradus)
  • minor #3377 rules - change default options (keradus)
  • minor #3378 SKIP_LINT_TEST_CASES - drop env (keradus)
  • minor #3379 MethodArgumentSpaceFixer - fixSpace is now private (keradus)
  • minor #3380 rules - drop rootless configurations (keradus)
  • minor #3381 rules - drop deprecated configurations (keradus)
  • minor #3382 DefinedFixerInterface - incorporate into FixerInterface (keradus)
  • minor #3383 FixerDefinitionInterface - drop getConfigurationDescription and getDefaultConfiguration (keradus)
  • minor #3384 diff-format option: drop sbd diff, use udiffer by default, drop SebastianBergmannDiffer and SebastianBergmannShortDiffer classes (keradus)
  • minor #3385 ConfigurableFixerInterface::configure - param is now not nullable and not optional (keradus)
  • minor #3386 ConfigurationDefinitionFixerInterface - incorporate into ConfigurableFixerInterface (keradus)
  • minor #3387 FixCommand - forbid passing 'config' and 'rules' options together (keradus)
  • minor #3388 Remove Helpers (keradus)
  • minor #3389 AccessibleObject - drop class (keradus)
  • minor #3390 Drop deprecated rules: blank_line_before_return, hash_to_slash_comment, method_separation, no_extra_consecutive_blank_lines, no_multiline_whitespace_before_semicolons and pre_increment (keradus)
  • minor #3456 AutoReview - drop references to removed rule (keradus)
  • minor #3659 use php-cs-fixer/diff ^2.0 (SpacePossum)
  • minor #3681 CiIntegrationTest - fix incompatibility from 2.x line (keradus)
  • minor #3740 NoUnusedImportsFixer - remove SF exception (SpacePossum)
  • minor #3771 UX: always set error_reporting in entry file, not Application (keradus)
  • minor #3922 Make some more classes final (ntzm, SpacePossum)
  • minor #3995 Change default config of native_function_invocation (dunglas, SpacePossum)
  • minor #4432 DX: remove empty sets from RuleSet (kubawerlos)
  • minor #4489 Fix ruleset @​PHPUnit50Migration:risky (kubawerlos)
  • minor #4620 DX: cleanup additional, not used parameters (keradus)
  • minor #4666 Remove deprecated rules: lowercase_constants, php_unit_ordered_covers, silenced_deprecation_error (keradus)
  • minor #4697 Remove deprecated no_short_echo_tag rule (julienfalque)
  • minor #4851 fix phpstan on 3.0 (SpacePossum)
  • minor #4901 Fix SCA (SpacePossum)
  • minor #5069 Fixed failing tests on 3.0 due to unused import after merge (GrahamCampbell)
  • minor #5096 NativeFunctionInvocationFixer - BacktickToShellExecFixer - fix integration test (SpacePossum)
  • minor #5171 Fix test (SpacePossum)
  • minor #5245 Fix CI for 3.0 line (keradus)
  • minor #5351 clean ups (SpacePossum)
  • minor #5364 DX: Do not display runtime twice on 3.0 line (keradus)
  • minor #5412 3.0 - cleanup (SpacePossum, keradus)
  • minor #5417 Further BC cleanup for 3.0 (keradus)

... (truncated)

Changelog

Sourced from friendsofphp/php-cs-fixer's changelog.

Changelog for v3.0.0

  • bug #5164 Differ - surround file name with double quotes if it contains spacing. (SpacePossum)
  • bug #5560 PSR2: require visibility only for properties and methods (kubawerlos)
  • bug #5576 ClassAttributesSeparationFixer: do not allow using v2 config (kubawerlos)
  • feature #4979 Pass file to differ (paulhenri-l, SpacePossum)
  • minor #3374 show-progress option: drop run-in and estimating, rename estimating-max to dots (keradus)
  • minor #3375 Fixers - stop exposing extra properties/consts (keradus)
  • minor #3376 Tokenizer - remove deprecations and legacy mode (keradus)
  • minor #3377 rules - change default options (keradus)
  • minor #3378 SKIP_LINT_TEST_CASES - drop env (keradus)
  • minor #3379 MethodArgumentSpaceFixer - fixSpace is now private (keradus)
  • minor #3380 rules - drop rootless configurations (keradus)
  • minor #3381 rules - drop deprecated configurations (keradus)
  • minor #3382 DefinedFixerInterface - incorporate into FixerInterface (keradus)
  • minor #3383 FixerDefinitionInterface - drop getConfigurationDescription and getDefaultConfiguration (keradus)
  • minor #3384 diff-format option: drop sbd diff, use udiffer by default, drop SebastianBergmannDiffer and SebastianBergmannShortDiffer classes (keradus)
  • minor #3385 ConfigurableFixerInterface::configure - param is now not nullable and not optional (keradus)
  • minor #3386 ConfigurationDefinitionFixerInterface - incorporate into ConfigurableFixerInterface (keradus)
  • minor #3387 FixCommand - forbid passing 'config' and 'rules' options together (keradus)
  • minor #3388 Remove Helpers (keradus)
  • minor #3389 AccessibleObject - drop class (keradus)
  • minor #3390 Drop deprecated rules: blank_line_before_return, hash_to_slash_comment, method_separation, no_extra_consecutive_blank_lines, no_multiline_whitespace_before_semicolons and pre_increment (keradus)
  • minor #3456 AutoReview - drop references to removed rule (keradus)
  • minor #3659 use php-cs-fixer/diff ^2.0 (SpacePossum)
  • minor #3681 CiIntegrationTest - fix incompatibility from 2.x line (keradus)
  • minor #3740 NoUnusedImportsFixer - remove SF exception (SpacePossum)
  • minor #3771 UX: always set error_reporting in entry file, not Application (keradus)
  • minor #3922 Make some more classes final (ntzm, SpacePossum)
  • minor #3995 Change default config of native_function_invocation (dunglas, SpacePossum)
  • minor #4432 DX: remove empty sets from RuleSet (kubawerlos)
  • minor #4489 Fix ruleset @​PHPUnit50Migration:risky (kubawerlos)
  • minor #4620 DX: cleanup additional, not used parameters (keradus)
  • minor #4666 Remove deprecated rules: lowercase_constants, php_unit_ordered_covers, silenced_deprecation_error (keradus)
  • minor #4697 Remove deprecated no_short_echo_tag rule (julienfalque)
  • minor #4851 fix phpstan on 3.0 (SpacePossum)
  • minor #4901 Fix SCA (SpacePossum)
  • minor #5069 Fixed failing tests on 3.0 due to unused import after merge (GrahamCampbell)
  • minor #5096 NativeFunctionInvocationFixer - BacktickToShellExecFixer - fix integration test (SpacePossum)
  • minor #5171 Fix test (SpacePossum)
  • minor #5245 Fix CI for 3.0 line (keradus)
  • minor #5351 clean ups (SpacePossum)
  • minor #5364 DX: Do not display runtime twice on 3.0 line (keradus)
  • minor #5412 3.0 - cleanup (SpacePossum, keradus)
  • minor #5417 Further BC cleanup for 3.0 (keradus)
  • minor #5418 Drop src/Test namespace (keradus)
  • minor #5436 Drop mapping of strings to boolean option other than yes/no (keradus)
  • minor #5440 Change default ruleset to PSR-12 (keradus)
  • minor #5477 Drop diff-format (keradus)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependency label Jun 1, 2021
@pimjansen
Copy link

Do we want majors? We can now pin it to to minors patches and security too

@pimjansen
Copy link

@localheinz what do you think?

@localheinz localheinz self-assigned this Jun 1, 2021
Copy link
Member

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@localheinz localheinz force-pushed the dependabot/composer/vendor-bin/php-cs-fixer/friendsofphp/php-cs-fixer-3.0.0 branch from 8045204 to 881737e Compare June 1, 2021 08:00
@localheinz localheinz requested a review from pimjansen June 1, 2021 08:07
@localheinz localheinz assigned pimjansen and unassigned localheinz Jun 1, 2021
@localheinz
Copy link
Member

@pimjansen

Can you take another look? I have made some changes to the configuration.

For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md.

@@ -9,8 +9,7 @@
'vendor-bin/',
])
->ignoreDotFiles(false)
->in(__DIR__)
->name('.php_cs.dist');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not necessary to explicitly configure the file name here since the configuration file now uses .php as file extension.

@pimjansen
Copy link

@pimjansen

Can you take another look? I have made some changes to the configuration.

For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.0.0/UPGRADE-v3.md.

We can also update dependabot to only allow security + patches. It is a new feature since this month. It means we won't push minors and majors via a CI job instead. Or just only refuse majors which can also work maybe

@pimjansen pimjansen merged commit 98130c6 into main Jun 4, 2021
@pimjansen pimjansen deleted the dependabot/composer/vendor-bin/php-cs-fixer/friendsofphp/php-cs-fixer-3.0.0 branch June 4, 2021 15:42
@localheinz
Copy link
Member

Thank you, @pimjansen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants