feat(mysql): Add parser support for IS [NOT] NULL (sqlc-dev#2651)

Jille · web-flow · commit 7a5fe4e0ff55 · 2023-08-28T15:44:05.000-07:00
to return a boolean column
diff --git a/internal/compiler/output_columns.go b/internal/compiler/output_columns.go
@@ -173,12 +173,17 @@ func (c *Compiler) outputColumns(qc *QueryCatalog, node ast.Node) ([]*Column, er
 				name = *res.Name
 			}
 			notNull := false
-			if n.Boolop == ast.BoolExprTypeNot && len(n.Args.Items) == 1 {
-				sublink, ok := n.Args.Items[0].(*ast.SubLink)
-				if ok && sublink.SubLinkType == ast.EXISTS_SUBLINK {
+			if len(n.Args.Items) == 1 {
+				switch n.Boolop {
+				case ast.BoolExprTypeIsNull, ast.BoolExprTypeIsNotNull:
 					notNull = true
-					if name == "" {
-						name = "not_exists"
+				case ast.BoolExprTypeNot:
+					sublink, ok := n.Args.Items[0].(*ast.SubLink)
+					if ok && sublink.SubLinkType == ast.EXISTS_SUBLINK {
+						notNull = true
+						if name == "" {
+							name = "not_exists"
+						}
 					}
 				}
 			}
diff --git a/internal/endtoend/testdata/comparisons/mysql/go/query.sql.go b/internal/endtoend/testdata/comparisons/mysql/go/query.sql.go
diff --git a/internal/endtoend/testdata/comparisons/mysql/query.sql b/internal/endtoend/testdata/comparisons/mysql/query.sql
@@ -24,8 +24,8 @@ SELECT count(*) <> 0 FROM bar;
 -- name: Equal :many
 SELECT count(*) = 0 FROM bar;
 
+-- name: IsNull :many
+SELECT id IS NULL FROM bar;
 
-
-
-
-
+-- name: IsNotNull :many
+SELECT id IS NOT NULL FROM bar;
diff --git a/internal/engine/dolphin/convert.go b/internal/engine/dolphin/convert.go
@@ -953,7 +953,18 @@ func (c *cc) convertIndexPartSpecification(n *pcast.IndexPartSpecification) ast.
 }
 
 func (c *cc) convertIsNullExpr(n *pcast.IsNullExpr) ast.Node {
-	return todo(n)
+	op := ast.BoolExprTypeIsNull
+	if n.Not {
+		op = ast.BoolExprTypeIsNotNull
+	}
+	return &ast.BoolExpr{
+		Boolop: op,
+		Args: &ast.List{
+			Items: []ast.Node{
+				c.convert(n.Expr),
+			},
+		},
+	}
 }
 
 func (c *cc) convertIsTruthExpr(n *pcast.IsTruthExpr) ast.Node {
diff --git a/internal/sql/ast/bool_expr_type.go b/internal/sql/ast/bool_expr_type.go
@@ -6,6 +6,10 @@ const (
 	BoolExprTypeAnd
 	BoolExprTypeOr
 	BoolExprTypeNot
+
+	// Added for MySQL
+	BoolExprTypeIsNull
+	BoolExprTypeIsNotNull
 )
 
 type BoolExprType uint

Original file line number	Diff line number	Diff line change
`@@ -173,12 +173,17 @@ func (c Compiler) outputColumns(qc QueryCatalog, node ast.Node) ([]*Column, er`
`173`	`173`	`name = *res.Name`
`174`	`174`	`}`
`175`	`175`	`notNull := false`
`176`		`- if n.Boolop == ast.BoolExprTypeNot && len(n.Args.Items) == 1 {`
`177`		`- sublink, ok := n.Args.Items[0].(*ast.SubLink)`
`178`		`- if ok && sublink.SubLinkType == ast.EXISTS_SUBLINK {`
	`176`	`+ if len(n.Args.Items) == 1 {`
	`177`	`+ switch n.Boolop {`
	`178`	`+ case ast.BoolExprTypeIsNull, ast.BoolExprTypeIsNotNull:`
`179`	`179`	`notNull = true`
`180`		`- if name == "" {`
`181`		`- name = "not_exists"`
	`180`	`+ case ast.BoolExprTypeNot:`
	`181`	`+ sublink, ok := n.Args.Items[0].(*ast.SubLink)`
	`182`	`+ if ok && sublink.SubLinkType == ast.EXISTS_SUBLINK {`
	`183`	`+ notNull = true`
	`184`	`+ if name == "" {`
	`185`	`+ name = "not_exists"`
	`186`	`+ }`
`182`	`187`	`}`
`183`	`188`	`}`
`184`	`189`	`}`