-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Split expense with deleted workspace #53701
Fix Split expense with deleted workspace #53701
Conversation
@Ollyws friendly ping on that one |
Reviewer Checklist
Screenshots/VideosAndroid: Native04_iOS_Safari.mp4Android: mWeb Chrome03_iOS_Native.mp4iOS: Native06_MacOS_Desktop.mp4iOS: mWeb Safari05_MacOS_Chrome.mp4MacOS: Chrome / Safari01_Android_Native.mp4MacOS: Desktop02_Android_Chrome.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/amyevans in version: 9.0.74-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.0.74-8 🚀
|
Explanation of Change
Broken options are shown during quick split actions - after removing workspace
Fixed Issues
$ #53392
PROPOSAL:
Tests
Offline tests
No changes
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
8mb.video-T4n-PXWXO7dD.mp4
Android: mWeb Chrome
8mb.video-wbH-I5hZhXNL.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov