Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for parsing some Ricoh Exif tags in Exiv2 #3101

Open
stevendinggang opened this issue Dec 30, 2024 · 1 comment
Open

support for parsing some Ricoh Exif tags in Exiv2 #3101

stevendinggang opened this issue Dec 30, 2024 · 1 comment
Labels
request feature request or any other kind of wish

Comments

@stevendinggang
Copy link

Is your feature request related to a problem?

I would like to contribute code to add support for parsing some Ricoh Exif tags in Exiv2, especially those related to image effects. I tried adding tag definition arrays like pentaxImageEffects in the code, but found it has limited effect. I am not sure how to properly implement support for these Ricoh tags.

Describe the solution you would like

I hope to get some guidance on the proper way to add support for Ricoh Exif tags in Exiv2. Specifically:

  1. Which files need to be modified to add new Exif tag definitions?
  2. How can Exiv2 be enhanced to fully parse the Raw file and Exif data structures of Ricoh cameras, beyond just defining tag arrays?
  3. Are there any coding conventions or best practices I should follow while working on this?

I can help test any implemented changes. I also have some sample Ricoh Raw files that I can provide if it would be helpful.

Describe alternatives you have considered

I investigated the ExifTool code that already supports a wide range of Ricoh tags. However, directly translating that parsing logic to Exiv2 is still challenging for me. I would appreciate any pointers on how to approach this in the context of Exiv2's architecture.

Desktop

  • OS and version: Ubuntu 22.04
  • Exiv2 version and source: Exiv2 0.27.5 from exiv2.org
  • Any software using exiv2 and source: N/A

Additional context

The list of Ricoh Exif tags on the ExifTool site covers the ones I would like to eventually support in Exiv2.

I tried adding Ricoh tag definitions like this in the code:

//! ImageEffects, tag 0x1010
const TagDetails pentaxImageEffects[] = {
     { 0, N_("Standard") },  
     { 1, N_("Vivid") },
     ...
};

But I realized more extensive changes are needed for proper parsing.

Please let me know if you have any advice on how I can move forward with implementing this feature. I would be very grateful for your guidance. Also, please feel free to let me know if you need me to provide any other information or sample files.

Thank you very much for your help!

@stevendinggang stevendinggang added the request feature request or any other kind of wish label Dec 30, 2024
@stevendinggang
Copy link
Author

I see that it seems that the current Ricoh is analyzed under pentax,
But should Ricoh still have its own exif?
I saw on exiftool that Pentax and Ricoh have different tags,
https://exiftool.org/TagNames/Pentax.html
https://exiftool.org/TagNames/Ricoh.html
I suspect that this is the reason why I modified pentaxmn'int.cpp and pentaxmn'int.Hpp in the code

//! ImageEffects, tag 0x1010
const TagDetails pentaxImageEffects[] = {
{ 0, N_("Standard") },
{ 1, N_("Vivid") },
{ 3, N_("Black & White") },
{ 5, N_("B&W Toning Effect") },
{ 6, N_("Setting 1") },
{ 7, N_("Setting 2") },
{ 9, N_("High-contrast B&W") },
{ 10, N_("Cross Process") },
{ 11, N_("Positive Film") },
{ 12, N_("Bleach Bypass") },
{ 13, N_("Retro") },
{ 15, N_("Miniature") },
{ 17, N_("High Key") }
};

Still ineffective,
So I would like to ask if anyone knows how to modify this Ricoh section and what to pay attention to when adding it?
Ricoh is currently also a very popular camera. thank you all。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
request feature request or any other kind of wish
Projects
None yet
Development

No branches or pull requests

1 participant