Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FortiGate WAF profile support #180

Merged
merged 4 commits into from
Jun 4, 2023
Merged

Add FortiGate WAF profile support #180

merged 4 commits into from
Jun 4, 2023

Conversation

abletsoff
Copy link
Contributor

Which category is this pull request?

  • A new feature/enhancement.
  • Fix an issue/feature-request.
  • An improvement to existing modules.
  • Other (Please mention below).

Where has this been tested?

  • Python Version
    • v3.x
    • v2.x
  • Operating System:
    • Linux (Debian GNU/Linux 11 (bullseye)
    • Windows
    • MacOS

Does this close any currently open issues?

[Mention any issue which this PR closes]

Does this add any new dependency?

[Mention if this PR includes any new library]

Does this add any new command line switch/argument?

[Mention if the changes add any new arguments like --arg]

Any other comments you would like to make?

[Anything more you'd want the reviewer to know]

@0xInfection
Copy link
Collaborator

Hi @abletsoff, many thanks for this MR! However it seems there are many variants of Fortinet products that actually block traffic / present a user with a blockpage. I'll be adding a few commits to your branch after which we can merge it!

Copy link
Collaborator

@0xInfection 0xInfection left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xInfection 0xInfection merged commit 8585cf4 into EnableSecurity:master Jun 4, 2023
@0xInfection 0xInfection added enhancement New feature, enhancements or bug fixes... code refactor Rewriting existing code... labels Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactor Rewriting existing code... enhancement New feature, enhancements or bug fixes...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants