Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugins' performance #170

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

redphx
Copy link
Contributor

@redphx redphx commented Dec 26, 2022

Which category is this pull request?

  • A new feature/enhancement.
  • Fix an issue/feature-request.
  • An improvement to existing modules.
  • Other (Please mention below).

Where has this been tested?

  • Python Version
    • v3.x
    • v2.x
  • Operating System:
    • Linux (Please specify distro)
    • Windows
    • MacOS

Does this close any currently open issues?

#169

Does this add any new dependency?

No

Does this add any new command line switch/argument?

No

Any other comments you would like to make?

@0xInfection 0xInfection self-assigned this Dec 27, 2022
@0xInfection 0xInfection added the code refactor Rewriting existing code... label Dec 27, 2022
@0xInfection
Copy link
Collaborator

Awesome work @redphx.

I'll be gradually testing the changes now. Kindly do not delete your branch as further changes might be required.
Once again, many thanks for the PR!

@redphx
Copy link
Contributor Author

redphx commented Dec 27, 2022

@0xInfection sure, I'll won't touch it! There are a few more things I want to do, like moving faster/simpler conditions (matchStatus()...) to the beginning of the function, but I'll save that for another PR, since this one is already big enough.

@0xInfection
Copy link
Collaborator

Tested several modules so far. Looks great. Detections work on all plugins tested so far. Gonna merge it and make a release shortly. Once again thanks @redphx!

@0xInfection 0xInfection merged commit 66bfb1e into EnableSecurity:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code refactor Rewriting existing code...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants