Add custom headers (except for user agent) for generic detection #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for HTTP Basic Authentication for example, which will get detected as a generic WAF otherwise.
0xInfection
reviewed
Apr 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for HTTP Basic Authentication for example, which will get detected as a generic WAF otherwise.
Before this commit the “normal” requests were made with the
Authorizationheader intact, whereas the generic request would remove theAuthorizationheader and result in a 403 Forbidden.Which category is this pull request?
Where has this been tested?
Does this close any currently open issues?
No, I just noticed it myself.
Does this add any new dependency?
No.
Does this add any new command line switch/argument?
No.
Any other comments you would like to make?
There is a quicker way to merge the dictionaries, but it is for Python 3.5 and above, so I hope this is okay.