Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修改深色模式下VS2013样式 #170

Merged
merged 23 commits into from
Jul 2, 2020
Merged

Conversation

LyonJack
Copy link
Contributor

修改VS2013Theme,修改简体中文资源字典中菜单名称

@LyonJack
Copy link
Contributor Author

IFS7{ IPHYP%A89L720`8ZY

@Dirkster99
Copy link
Owner

Wow very cool improvement indeed :-) Thank you so much for these fixes and style improvements 🥇

When testing, I've seen that the Light VS 2013 Theme looks a little broken now, would you be able to fix this please?

Untitled

There are Surpresse Message in Chinese in DockingManager.cs - Can you please translate these into English? I have tried Google Translate but does not really output much useful English :-(

There is a AvalonDockIcon.design file in the repository. Is this left there by mistake or on purpose? What program would I need to open it?

@Dirkster99 Dirkster99 merged commit 5ea2131 into Dirkster99:master Jul 2, 2020
@LyonJack
Copy link
Contributor Author

LyonJack commented Jul 3, 2020

AvalonDockIcon.design is a file of icons,open it by Microsoft Expression Design 4
1593736924(1)
@Dirkster99

@Dirkster99
Copy link
Owner

I don't have Microsoft Expression Design and there is not Community Edition (?). Can we use a file format that is also available in Microsoft Expression Blen (Community)?

Untitled

@LyonJack
Copy link
Contributor Author

LyonJack commented Jul 3, 2020

this file just can be opened by that soft,Its a great soft for wpf,we can design
Path gemetry or transfer an AI to that, you can search expression studio try to get it, or tomorrow I send a url to you

@Dirkster99
Copy link
Owner

Its OK if you can send me the url later :-) I found in the meantime that we broke a feature in the last pull request

The feature was implemented with this pull request:
#146

Dirkster99 added a commit that referenced this pull request Jul 3, 2020
@LyonJack
Copy link
Contributor Author

LyonJack commented Jul 4, 2020

Microsoft Expression Studio 4 Ultimate is not support,I just have a chinese version,should I send a email of it to your?

@LyonJack
Copy link
Contributor Author

LyonJack commented Jul 4, 2020

image
these Figures are created by Microsoft Expression Studio 4 Ultimate,Microsoft Expression Design is one part of this sln

@Dirkster99
Copy link
Owner

Dirkster99 commented Aug 14, 2020

Hi LyonJack,

I found a bug in the styling that bothered me quit a bit and is only visible in Ähnlich and Edi - I am not sure why the issue is not visible in MLibTest :-(.

The issue is that the ContextMenu looks broken and the ToolTip is no longer usable:

来自Google翻译的翻译

嗨LyonJack,
我在样式中发现了一个困扰我退出的错误,并且仅在Ähnlich和Edi中可见-我不确定为什么该问题在MLibTest中不可见:-(。
问题是ContextMenu看起来坏了,ToolTip不再可用:

BlackToolTip

BrockenContextMenu

BrockenCOntextMenu1

For now I have resolved these issues by removing the additional ToolTip and ContextMenu styles from the Generic.xaml file as shown in the linked commits and everything looks OK as shown below.

I just wonder if you need these styles and if so if there is a better solution?

Thanks Dirk

来自Google翻译的翻译

现在,我已经通过从Generic.xaml文件中删除其他ToolTip和ContextMenu样式(如链接提交中所示)解决了这些问题,如下所示,一切看起来都不错。
我只是想知道您是否需要这些样式,是否需要更好的解决方案?
谢谢德克

Untitled

Untitled1

Here is a test application to verify the issue and resolution:
Aehnlich.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants