Allow document to be docked in floating window. #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he SelectedIndex of the TabControl to the selectedContentIndex of the pane model. This will cause the tabcontrol do switch to the correct panel when IsActive is set.
Dock document in floating window. Todo: check undock last document.
Reinstated highlight when window is active.
|
Hi, Unfortunately, I am not able to merge this as it is right now :-( - My guess is that my latest change (removal of Xceed.Wpf. namespaces and switching to TAB based coding style) makes this merge impossible. I could try and repair this in a local folder and fix this with another pull request but then you are no longer the visible contributor of this change and you might even be able to repair this more accurately than me since you know your changes better... Would you be able to please re-apply your changes on a current copy of my repository? |
|
Hi,
Thanks for your message. We already figured it was not an easy task. We'll look into applying the changes to a newer version took keep up to date. Thanks for considering applying the changes.
It might take some time before it is done.
Groeten,
Marco
ing. Marco Konijnenburg | Head Software Engineering group
AMOLF | Advanced Research Center for Nanolithography (ARCNL)
Science Park 104, 1098XG Amsterdam, The Netherlands
P.O. Box 41883, 1009DB Amsterdam, The Netherlands
T. +31-20-7547100
http://www.amolf.nl <http://www.amolf.nl/> | http://www.arcnl.nl <http://www.arcnl.nl/>
…-----Original message-----
From: Dirkster99 <[email protected]>
Sent: Tuesday 21st January 2020 16:59
To: Dirkster99/AvalonDock <[email protected]>
Cc: SE <[email protected]>; Author <[email protected]>
Subject: Re: [Dirkster99/AvalonDock] Allow document to be docked in floating window. (#107)
Hi,
thank you for your contribution.
Unfortunately, I am not able to merge this as it is right now :-( - My guess is that my latest change (removal of Xceed.Wpf. namespaces and switching to TAB based coding style) makes this merge impossible. I could try and repair this in a local folder and fix this with another pull request but then you are no longer the visible contributor of this change and you might even be able to repair this more accurately than me since you know your changes better...
Would you be able to please re-apply your changes on a current copy of my repository?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Added implementation to support docking documents in a floating window. |
|
Can you contact me directly to discuss your plans with the library? |
|
I have sent 2 messages via Email please let me know if you did not receive these.... |
Added check for Model.Root not null, or should it always be set somewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addition is to allow documents to be docked in a floating window, like Visual Studio does.