Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GetEngineFactoryXXXType and LoadGraphicsEngineXXX to Diligent namespace #5

Closed
hals1010 opened this issue Mar 1, 2018 · 0 comments
Closed

Move GetEngineFactoryXXXType and LoadGraphicsEngineXXX to Diligent namespace #5

hals1010 opened this issue Mar 1, 2018 · 0 comments

Comments

@hals1010
Copy link

hals1010 commented Mar 1, 2018

Small issue - the typedefs GetEngineFactoryXXXType and the functions LoadGraphicsEngineXXX are not part of the Diligent namespace.

This leads to code like

Diligent::EngineD3D11Attribs DeviceAttribs;
GetEngineFactoryD3D11Type pfnEngineFactoryD3D11;

LoadGraphicsEngineD3D11(pfnEngineFactoryD3D11);

instead of

Diligent::EngineD3D11Attribs DeviceAttribs;
Diligent::GetEngineFactoryD3D11Type pfnEngineFactoryD3D11;

Diligent::LoadGraphicsEngineD3D11(pfnEngineFactoryD3D11);

Best
Jörn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hals1010