Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes/UI changes #27

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixes/UI changes #27

wants to merge 10 commits into from

Conversation

Akshaygore1
Copy link

Overview

This PR includes several updates to the user interface to enhance usability and improve the overall design.

Changes Made

  1. Dynamic Navbar: The navbar has been updated to include dynamic links for Docs, Blog, Get Started, and GitHub. This change allows for easier navigation and improved user experience.
  2. Height Adjustment: Resolved a height issue with the terminal and search command input. This adjustment ensures that the components are properly sized and enhance the user interaction experience.
  3. Footer Simplification: The footer section has been simplified. Previously cluttered with excessive elements, it now presents a straightforward contact method, making it cleaner and more user-friendly.
  4. Added Header, Footer to layout so it can be share across all routes

Testing

  1. Ensure that all navbar links are functioning correctly and redirecting to the intended pages.
  2. Verify that the height adjustments have resolved any previous display issues.
  3. Check the footer for proper alignment and functionality of contact methods.

Screenshots (if applicable)

Screenshot 2024-10-03 at 2 12 34 AM Screenshot 2024-10-03 at 2 12 37 AM

@sashpawar11 sashpawar11 mentioned this pull request Oct 6, 2024
Closed
@lucifercr07
Copy link
Contributor

@Akshaygore1 please resolve conflicts.

@Akshaygore1
Copy link
Author

I’m creating a new pull request, and there are quite a few changes. Hope you don’t mind, as there are several conflicts to resolve.

@Akshaygore1 Akshaygore1 reopened this Oct 11, 2024
@lucifercr07
Copy link
Contributor

@Akshaygore1 have fixed the links in footer, we'd ideally want to maintain parity with dicedb.io. Hence let's not change UX of other elements.

@Akshaygore1
Copy link
Author

@lucifercr07 ok thanks

@Akshaygore1
Copy link
Author

@lucifercr07 removed "use client" so it will render on server

@Akshaygore1 Akshaygore1 reopened this Oct 11, 2024
@lucifercr07
Copy link
Contributor

@Akshaygore1 please resolve the conflicts.

@Akshaygore1
Copy link
Author

@Akshaygore1 please resolve the conflicts.

Done

@lucifercr07
Copy link
Contributor

@Akshaygore1 build is failing.

@Akshaygore1
Copy link
Author

Akshaygore1 commented Oct 17, 2024 •
edited
Loading

@Akshaygore1 build is failing.

Added Formatting can you check now

The tests are failing, but I don't believe the issue is related to the UI, as it shouldn't affect the functionality. Could you please review the tests?

@lucifercr07
Copy link
Contributor

@Akshaygore1 please resolve build failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaviiSuri KaviiSuri Awaiting requested review from KaviiSuri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Akshaygore1 @lucifercr07