Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Config management problems + interest for PR ? #573

Open
JonRiv opened this issue Sep 27, 2017 · 4 comments
Open

Config management problems + interest for PR ? #573

JonRiv opened this issue Sep 27, 2017 · 4 comments

Comments

@JonRiv
Copy link

JonRiv commented Sep 27, 2017

Hello,

I read a lot of users are wondering how to connect to different accounts, and also people wondering why there are heavy differences between sim and trade behavior.

There is a @zenbot:conf object that is loaded with either sample-conf.js or conf.js in boot.js, and then requested with the get('conf') method. The problem is that this object doesn't take into account command parameters (including the --conf one), which results in different configurations depending on the modules implementation.

Some only request the global object (exchanges), when others parse command options to update it (trade/sim). In this case there is also the problem of --conf file rewriting other command options, while NOT rewriting the ones in @zenbot:conf, hence NO multiple accounts).

I think the default behavior should be :

sample-conf.js => conf.js => --conf file => command options

What do you think, if you are interested I can clean up my local patch and submit a PR.

Best,

@DeviaVir
Copy link
Owner

I think a PR is always welcome, it's also usually easier to reason about code than about words, at least for me.

@haxwell
Copy link
Contributor

haxwell commented Dec 19, 2017

@JonRiv Hey, could you see if PR #912 addresses this issue for you?

@JonRiv
Copy link
Author

JonRiv commented Jan 15, 2018

I think it does, at least the part allowing multiple configuration files.

As far as I remember, the modules (trade, sim) were also managing their own config which is a problem you can not solve from boot.js only.

@DeviaVir
Copy link
Owner

Can you check if that is still the case after the recent changes in unstable?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants