Merge pull request jamesls#310 from jamesls/sample-from-set

bmerry · web-flow · commit f753f81d86d9 · 2021-10-12T10:21:18.000+02:00
Fix DeprecationWarning for sampling from a set
diff --git a/fakeredis/_server.py b/fakeredis/_server.py
@@ -1937,7 +1937,7 @@ def spop(self, key, count=None):
         if count is None:
             if not key.value:
                 return None
-            item = random.sample(key.value, 1)[0]
+            item = random.sample(list(key.value), 1)[0]
             key.value.remove(item)
             key.updated()
             return item
@@ -1956,10 +1956,10 @@ def srandmember(self, key, count=None):
             if not key.value:
                 return None
             else:
-                return random.sample(key.value, 1)[0]
+                return random.sample(list(key.value), 1)[0]
         elif count >= 0:
             count = min(count, len(key.value))
-            return random.sample(key.value, count)
+            return random.sample(list(key.value), count)
         else:
             items = list(key.value)
             return [random.choice(items) for _ in range(-count)]
